Sb wizard part1 #256
Open
Sb wizard part1 #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miczyg1
changed the base branch from
dasharo
to
fix_file_explorer_empty_statement
Contributor
|
@miczyg1 shouldn't we track it in a separate repo? |
Contributor
Author
It doesn't make sense IMO. |
Contributor
Author
|
Operation confirmed with tests: Dasharo/open-source-firmware-validation#915 |
Contributor
|
@mkopec @SergiiDmytruk Can you please at lest briefly go through the common changes in this MR (so not the Application directory) to make sure we are aware of what's being changed, especially in the scenario with this App being disabled (which is the default)? |
DasharoModulePkg/Library/DasharoVariablesLib/DasharoVariablesLib.c
Outdated
Show resolved
Hide resolved
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfig.vfr
Outdated
Show resolved
Hide resolved
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c
Outdated
Show resolved
Hide resolved
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigStrings.uni
Outdated
Show resolved
Hide resolved
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigStrings.uni
Outdated
Show resolved
Hide resolved
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigStrings.uni
Outdated
Show resolved
Hide resolved
Member
|
The application itself isn't done yet, right? I tried it in QEMU and it seemed unfinished. |
Contributor
Author
Yes, we are merely past the first phase of development. 2 or 3 are still ahead of us. |
SergiiDmytruk
force-pushed
the
fix_file_explorer_empty_statement
branch
from
5d2789a to
1cb64d6
Compare
miczyg1
force-pushed
the
sb_wizard_part1
branch
2 times, most recently
from
25eb939 to
47575fa
Compare
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…me form Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…tions Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…V Boot path Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Co-authored-by: SergiiDmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
miczyg1
force-pushed
the
sb_wizard_part1
branch
from
47575fa to
008ea3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.