Skip to content

Commit

Permalink
Remove dashlane_authenticator 2FA path
Browse files Browse the repository at this point in the history
  • Loading branch information
Mikescops committed Aug 19, 2024
1 parent 6bf6b21 commit e4c658c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 23 deletions.
1 change: 0 additions & 1 deletion src/endpoints/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export * from './getTeamMembers.js';
export * from './getTeamReport.js';
export * from './listDevices.js';
export * from './listTeamDevices.js';
export * from './performDashlaneAuthenticatorVerification.js';
export * from './performDuoPushVerification.js';
export * from './performEmailTokenVerification.js';
export * from './performTotpVerification.js';
Expand Down
18 changes: 0 additions & 18 deletions src/endpoints/performDashlaneAuthenticatorVerification.ts

This file was deleted.

7 changes: 3 additions & 4 deletions src/modules/auth/registerDevice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { doSSOVerification } from './sso/index.js';
import { doConfidentialSSOVerification } from './confidential-sso/index.js';
import {
completeDeviceRegistration,
performDashlaneAuthenticatorVerification,
performDuoPushVerification,
performEmailTokenVerification,
performTotpVerification,
Expand All @@ -29,6 +28,9 @@ export const registerDevice = async (params: RegisterDevice) => {

const nonEmptyVerifications = verifications.filter((method) => method.type);

// Remove dashlane_authenticator from the list of verification methods as it is a deprecated method
nonEmptyVerifications.filter((method) => method.type !== 'dashlane_authenticator');

const selectedVerificationMethod =
nonEmptyVerifications.length > 1
? await askVerificationMethod(nonEmptyVerifications)
Expand All @@ -43,9 +45,6 @@ export const registerDevice = async (params: RegisterDevice) => {
if (selectedVerificationMethod.type === 'duo_push') {
logger.info('Please accept the Duo push notification on your phone.');
({ authTicket } = await performDuoPushVerification({ login }));
} else if (selectedVerificationMethod.type === 'dashlane_authenticator') {
logger.info('Please accept the Dashlane Authenticator push notification on your phone.');
({ authTicket } = await performDashlaneAuthenticatorVerification({ login }));
} else if (selectedVerificationMethod.type === 'totp') {
const otp = await askOtp();
({ authTicket } = await performTotpVerification({
Expand Down

0 comments on commit e4c658c

Please sign in to comment.