feat: account recovery #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@quadristan
|
Mikescops
reviewed
Jul 9, 2024
| @@ -113,6 +114,11 @@ export const rootCommands = (params: { program: Command }) => { | |||
| .description('Backup your local vault (will use the current directory by default)') | |||
| .action(runBackup); | |||
|
|
|||
| program | |||
| .command('recover-account') | |||
| .description('interactively login to an account with a recovery key') | |||
There was a problem hiding this comment.
Suggested change
| .description('interactively login to an account with a recovery key') | |
| .description('Interactively login to an account with a recovery key') |
Mikescops
reviewed
Jul 9, 2024
Comment on lines
+30
to
+32
| } catch (e) { | ||
| logger.error('Failed to decrypt MP. Maybe the ARK entered is incorrect'); | ||
| throw e; |
There was a problem hiding this comment.
Suggested change
| } catch (e) { | |
| logger.error('Failed to decrypt MP. Maybe the ARK entered is incorrect'); | |
| throw e; | |
| } catch (error) { | |
| logger.error('Failed to decrypt Master Password. Maybe the ARK (Account Recovery Key) entered is incorrect'); | |
| throw error; |
Mikescops
reviewed
Jul 9, 2024
| import { decryptAesCbcHmac256, getDerivateUsingParametersFromEncryptedData } from '../../crypto/decrypt'; | ||
| import { deserializeEncryptedData } from '../../crypto/encryptedDataDeserialization'; | ||
|
|
||
| function cleanArk(input: string): string { |
There was a problem hiding this comment.
use arrow function please, here and below
Mikescops
reviewed
Jul 9, 2024
|
|
||
| export const askConfirmShowMp = async () => { | ||
| const response = await confirm({ | ||
| message: 'Do you want to see the masterpassword that will be unlocked by this recovery key?', |
There was a problem hiding this comment.
Suggested change
| message: 'Do you want to see the masterpassword that will be unlocked by this recovery key?', | |
| message: 'Do you want to see the master password that will be unlocked by this recovery key?', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR brings the functionality of using ARK to log in with the CLI, optionally recovering the MP with a recover-account command
It will allow users who have issue with their ARK to get more information.
User XP: