feat: Add option to remove default stopwords from word summary #1676
Open
jabahm wants to merge 1 commit intoData-Centric-AI-Community:developfrom
Open
feat: Add option to remove default stopwords from word summary #1676jabahm wants to merge 1 commit intoData-Centric-AI-Community:developfrom
jabahm wants to merge 1 commit intoData-Centric-AI-Community:developfrom
Conversation
fabclmnt
force-pushed
the
feature/remove-default-stopwords-option-1655
branch
from
f9e599a to
3083e4f
Compare
fabclmnt
force-pushed
the
feature/remove-default-stopwords-option-1655
branch
from
3083e4f to
b32f973
Compare
fabclmnt
force-pushed
the
feature/remove-default-stopwords-option-1655
branch
from
b32f973 to
0a00865
Compare
fabclmnt
requested changes
Mar 11, 2025
Collaborator
fabclmnt
left a comment
fabclmnt
left a comment
There was a problem hiding this comment.
Hi @jabahm ,
thank you for you contribution!
This functionality can be achieve by using the stopwords config already available in the package.
Perhaps you could share a bit more on what is the improvement that you expect this new development will bring, given the existing functionality.
Regarding the implementation, that are certain additions that I would review or remove in order to eliminate complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature to provide greater flexibility in word summary analysis by adding the following enhancements:
remove_default_stopwordsallows users to enable or disable the removal of default English stopwords.keep_stopwordsparameter to retain specific stopwords even whenremove_default_stopwordsis enabled.Closes #1655