fixup! Refactor canned file loading

test/indexer/__init__.py

@@ -3,7 +3,9 @@
     abstractmethod,
 )
 import json
-import os
+from pathlib import (
+    Path,
+)
 from typing import (
     Generic,
     Literal,
@@ -91,8 +93,8 @@ class CannedFileTestCase(AzulUnitTestCase):
     """
 
     @classmethod
-    def _data_path(cls, module: Literal['service', 'indexer'], path: str) -> str | bytes:
-        return os.path.join(config.project_root, 'test', module, 'data', path)
+    def _data_path(cls, module: Literal['service', 'indexer']) -> Path:
+        return Path(config.project_root) / 'test' / module / 'data'
 
     @classmethod
     def _load_canned_file(cls,
@@ -118,7 +120,7 @@ def _load_canned_file_version(cls,
                                   ) -> Union[MutableJSONs, MutableJSON]:
         suffix = '' if version is None else '.' + version
         file_name = f'{uuid}{suffix}.{extension}.json'
-        with open(cls._data_path('indexer', file_name), 'r') as infile:
+        with open(cls._data_path('indexer') / file_name, 'r') as infile:
             return json.load(infile)
 
 

test/pfb_test_case.py

@@ -1,5 +1,4 @@
 import json
-import os
 
 import fastavro
 
@@ -19,8 +18,8 @@ def _assert_pfb_schema(self, schema):
         def to_json(records):
             return json.dumps(records, indent=4, sort_keys=True)
 
-        results_file = self._data_path('service', 'pfb_manifest.schema.json')
-        if os.path.exists(results_file):
+        results_file = self._data_path('service') / 'pfb_manifest.schema.json'
+        if results_file.exists():
             with open(results_file, 'r') as f:
                 expected_records = json.load(f)
             self.assertEqual(expected_records, json.loads(to_json(schema)))