Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbatim JSONL manifest issues #6453

Closed
nadove-ucsc opened this issue Jul 29, 2024 · 2 comments
Closed

Verbatim JSONL manifest issues #6453

nadove-ucsc opened this issue Jul 29, 2024 · 2 comments
Assignees
@nadove-ucsc
Labels
- [priority] Medium bug [type] A defect preventing use of the system as specified demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team manifests [subject] Generation and contents of manifests orange [process] Done by the Azul team

Comments

@nadove-ucsc
Copy link
Contributor

nadove-ucsc commented Jul 29, 2024 •
edited
Loading

  1. contents property should be renamed to value
  2. Value of the type property should be more specific for HCA (e.g. "sequence_file" instead of "file")
@nadove-ucsc nadove-ucsc self-assigned this Jul 29, 2024
@github-actions github-actions bot added the orange [process] Done by the Azul team label Jul 29, 2024
@nadove-ucsc nadove-ucsc added bug [type] A defect preventing use of the system as specified manifests [subject] Generation and contents of manifests - [priority] Medium labels Jul 29, 2024
@nadove-ucsc nadove-ucsc changed the title HCA JSONL issues JSONL issues Jul 29, 2024
@dsotirho-ucsc dsotirho-ucsc changed the title JSONL issues Verbatim JSONL manifest issues Jul 30, 2024
nadove-ucsc added a commit that referenced this issue Jul 31, 2024
@nadove-ucsc
Rename contents to value in JSONL manifest (#6453)
c4c139c
@nadove-ucsc nadove-ucsc mentioned this issue Jul 31, 2024
Merged
nadove-ucsc added a commit that referenced this issue Jul 31, 2024
@nadove-ucsc
[r] Use DCP2 schema type for HCA replica_type (#6453)
78ea621
nadove-ucsc added a commit that referenced this issue Jul 31, 2024
@nadove-ucsc
Rename contents to value in JSONL manifest (#6453)
d4dac36
nadove-ucsc added a commit that referenced this issue Jul 31, 2024
@nadove-ucsc
[r] Use DCP2 schema name for HCA replica_type (#6453)
17ef083
nadove-ucsc added a commit that referenced this issue Jul 31, 2024
@nadove-ucsc
[r] Use DCP2 schema name for HCA replica_type (#6453)
81ccef2
nadove-ucsc added a commit that referenced this issue Jul 31, 2024
@nadove-ucsc
[r] Use DCP2 schema name for HCA replica_type (#6453)
f7f5f27
@nadove-ucsc nadove-ucsc added the demo [process] To be demonstrated at the end of the sprint label Aug 3, 2024
@nadove-ucsc
Copy link
Contributor Author

For demo, create a small JSONL manifest on a main HCA deployment. Show that the content property has been renamed to value. Show that the type property now shows more specific entity types (e.g. sequence_file instead of file).

achave11-ucsc pushed a commit that referenced this issue Aug 7, 2024
@nadove-ucsc @achave11-ucsc
Rename contents to value in JSONL manifest (#6453)
5912057
achave11-ucsc pushed a commit that referenced this issue Aug 7, 2024
@nadove-ucsc @achave11-ucsc
[r] Use DCP2 schema name for HCA replica_type (#6453)
770590e
nadove-ucsc added a commit that referenced this issue Aug 8, 2024
@nadove-ucsc
fixup! [r] Use DCP2 schema name for HCA replica_type (#6453)
086ac10
@hannes-ucsc
Copy link
Member

hannes-ucsc commented Aug 13, 2024 •
edited
Loading

For demo, attempt to reproduce. See above.

achave11-ucsc pushed a commit that referenced this issue Aug 14, 2024
@nadove-ucsc @achave11-ucsc
Rename contents to value in JSONL manifest (#6453)
db4a9b6
achave11-ucsc pushed a commit that referenced this issue Aug 14, 2024
@nadove-ucsc @achave11-ucsc
[r] Use DCP2 schema name for HCA replica_type (#6453)
7766c1d
achave11-ucsc added a commit that referenced this issue Aug 14, 2024
@achave11-ucsc
[r] Fix: Verbatim JSONL manifest issues (#6453, PR #6459)
e1bb690
@nadove-ucsc nadove-ucsc added the demoed [process] Successfully demonstrated to team label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadove-ucsc nadove-ucsc

Labels
- [priority] Medium bug [type] A defect preventing use of the system as specified demo [process] To be demonstrated at the end of the sprint demoed [process] Successfully demonstrated to team manifests [subject] Generation and contents of manifests orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannes-ucsc @nadove-ucsc