Refactor indices to accomodate replicas (#5358) #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5589 +/- ##
===========================================
- Coverage 83.75% 83.71% -0.05%
===========================================
Files 152 152
Lines 18870 18810 -60
===========================================
- Hits 15805 15747 -58
+ Misses 3065 3063 -2
☔ View full report in Codecov by Sentry. |
dsotirho-ucsc
force-pushed
the
issues/hannes-ucsc/5358-fix-merge-error
branch
from
f0d8823
to
4db335c
Compare
dsotirho-ucsc
added
the
sandbox
dsotirho-ucsc
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #5361, fixing a merge error I introduced there.
Replaces PR #5588 which was opened with the wrong branch name.
Connected issues: #5358
Checklist
Author
developissues/<GitHub handle of author>/<issue#>-<slug>For each connected issue, there is at least one commit whose title references that issueptag to titles of partial commitspartiallabel to PR or this PR completely resolves all connected issuespartiallabel1 when the issue title describes a problem, the corresponding PR
title is
Fix:followed by the issue titleAuthor (reindex, API changes)
rtag to commit title or this PR does not require reindexingreindexlabel to PR or this PR does not require reindexingAPIor this PR does not modify a REST APIa(A) tag to commit title for backwards (in)compatible changes or this PR does not modify a REST APIapp.pyor this PR does not modify a REST APIAuthor (chains)
baselabel to the blocking PR or this PR is not chained to another PRchainedlabel to this PR or this PR is not chained to another PRAuthor (upgrading)
utag to commit title or this PR does not require upgradingupgradelabel to PR or this PR does not require upgradingAuthor (operator tasks)
Author (hotfixes)
Ftag to main commit title or this PR does not include permanent fix for a temporary hotfixprodbranch has no temporary hotfixes for any connected issuesAuthor (before every review)
develop, squashed old fixupsmake requirements_updateor this PR does not touch requirements*.txt, common.mk, Makefile and DockerfileRtag to commit title or this PR does not touch requirements*.txtreqslabel to PR or this PR does not touch requirements*.txtmake integration_testpasses in personal deployment or this PR does not touch functionality that could break the ITPeer reviewer (after requesting changes)
Uncheck the Author (before every review) checklists.
Peer reviewer (after approval)
Primary reviewer (after requesting changes)
Uncheck the before every review checklists. Update the
N reviewslabel.Primary reviewer (after approval)
demoorno demono demono sandboxN reviewslabel is accurateOperator (before pushing merge the commit)
reindexlabel andrcommit title tagno demoupgradedevelopdevand addedsandboxlabel or PR is labeledno sandboxanvildevor PR is labeledno sandboxanvilprodor PR is labeledno sandboxsandboxdeployment or PR is labeledno sandboxanvilboxdeployment or PR is labeledno sandboxhammerboxdeployment or PR is labeledno sandboxsandboxdeployment or PR is labeledno sandboxanvilboxdeployment or PR is labeledno sandboxhammerboxdeployment or PR is labeledno sandboxsandboxor this PR does not remove catalogs or otherwise causes unreferenced indicesanvilboxor this PR does not remove catalogs or otherwise causes unreferenced indiceshammerboxor this PR does not remove catalogs or otherwise causes unreferenced indicessandboxor this PR does not require reindexingsandboxanvilboxor this PR does not require reindexingsandboxhammerboxor this PR does not require reindexingsandboxsandboxor this PR does not require reindexingsandboxanvilboxor this PR does not require reindexingsandboxhammerboxor this PR does not require reindexingsandboxpif the PR is labeledpartialOperator (chain shortening)
developor this PR is not labeledbasechainedlabel from the blocked PR or this PR is not labeledbasebasebaselabel from this PR or this PR is not labeledbaseOperator (after pushing the merge commit)
devor PR is labeledno sandboxanvildevor PR is labeledno sandboxanvilprodor PR is labeledno sandboxdev1dev1anvildev1anvildev1anvilprod1anvilprod1devanvildevanvilprod1 When pushing the merge commit is skipped due to the PR being
labelled
no sandbox, the next build triggered by a PR whose merge commit ispushed determines this checklist item.
Operator (reindex)
devor this PR does not remove catalogs or otherwise causes unreferenced indicesanvildevor this PR does not remove catalogs or otherwise causes unreferenced indicesanvilprodor this PR does not remove catalogs or otherwise causes unreferenced indicesdevor this PR does not require reindexinganvildevor this PR does not require reindexinganvilprodor this PR does not require reindexingdevor this PR does not require reindexinganvildevor this PR does not require reindexinganvilprodor this PR does not require reindexingdevdeployment or this PR does not require reindexinganvildevdeployment or this PR does not require reindexinganvilproddeployment or this PR does not require reindexingOperator
Shorthand for review comments
Lline is too longWline wrapping is wrongQbad quotesFother formatting problem