Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion 2024-08-27 prod (#6519) #6525

Merged
merged 17 commits into from
Aug 30, 2024
Merged

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Aug 28, 2024

Connected issue: #6519

Notes

Checklist

Author

  • Target branch is prod
  • Name of PR branch matches promotions/yyyy-mm-dd-prod
  • On ZenHub, PR is connected to the promotion issue it resolves
  • PR description links to connected issue
  • Title of connected issue matches Promotion yyyy-mm-dd
  • PR title starts with title of connected issue followed by prod
  • PR title references the connected issue

Author (reindex, API changes)

  • This PR is labeled reindex:prod or the changes introduced by it will not require reindexing of prod
  • This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod or requires a full reindex or is not labeledreindex:prod

Author (upgrading deployments)

  • This PR is labeled upgrade or does not require upgrading deployments
  • This PR is labeled deploy:shared or does not modify docker_images.json, and does not require deploying the shared component for any other reason
  • This PR is labeled deploy:gitlab or does not require deploying the gitlab component
  • This PR is labeled deploy:runner or does not require deploying the runner image

System administrator (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • Moved ticket to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Pushed PR branch to GitHub
  • Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Made a backup of the GitLab data volume in prod (see operator manual for details) or this PR is not labeled backup:gitlab
  • Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Checked the items in the next section or this PR is labeled deploy:gitlab
  • PR is assigned to only the system administrator or this PR is not labeled deploy:gitlab

System administrator

  • Background migrations for prod.gitlab are complete or this PR is not labeled deploy:gitlab
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Ran _select prod.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Deleted PR branch from GitHub
  • Moved connected issue to Merged stable column on ZenHub
  • Moved promoted issues from Merged lower to Merged stable column on ZenHub
  • Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

  • Deindexed all unreferenced catalogs in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Deindexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Indexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Started reindex in prod or this PR does not require reindexing prod
  • Checked for, triaged and possibly requeued messages in both fail queues in prod or this PR does not require reindexing prod
  • Emptied fail queues in prod or this PR does not require reindexing prod

Operator

  • PR is assigned to only the system administrator

System administrator

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (f4f4375) to head (347b2fb).
Report is 19 commits behind head on prod.

Files with missing lines Patch % Lines
src/azul/terraform.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             prod    #6525      +/-   ##
==========================================
- Coverage   85.42%   85.39%   -0.03%     
==========================================
  Files         156      156              
  Lines       20674    20682       +8     
==========================================
+ Hits        17660    17662       +2     
- Misses       3014     3020       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Aug 28, 2024

Coverage Status

coverage: 85.415% (-0.02%) from 85.438%
when pulling 347b2fb on promotions/2024-08-27-prod
into 27c4aef on prod.

@dsotirho-ucsc dsotirho-ucsc added deploy:shared [process] PR requires deploying `shared` component reindex:prod [process] PR requires reindexing prod labels Aug 28, 2024
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannes-ucsc hannes-ucsc added the 1 review [process] Lead requested changes once label Aug 28, 2024
@hannes-ucsc hannes-ucsc removed their assignment Aug 28, 2024
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deploy late Friday so that the reindex occurs over the weekend.

Note that I removed some potentially confusing verbiage from the description.

@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Aug 29, 2024
@dsotirho-ucsc dsotirho-ucsc merged commit 32ba09e into prod Aug 30, 2024
9 checks passed
@dsotirho-ucsc dsotirho-ucsc deleted the promotions/2024-08-27-prod branch September 3, 2024 15:30
@hannes-ucsc hannes-ucsc removed their assignment Sep 4, 2024
achave11-ucsc added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 review [process] Lead requested changes once deploy:shared [process] PR requires deploying `shared` component no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team reindex:prod [process] PR requires reindexing prod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants