-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: 96cd562 (#6344, PR #6585) cb830191 (#6347, PR #6589) #6588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6588 +/- ##
========================================
Coverage 85.38% 85.38%
========================================
Files 155 155
Lines 20754 20754
========================================
Hits 17720 17720
Misses 3034 3034
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hannes-ucsc
changed the title
Backport: 96cd562 (#6344, PR #6585)
Backport: 96cd562 (#6344, PR #6585) (#6347, PR #6589)
Sep 21, 2024
hannes-ucsc
force-pushed
the
backports/96cd562
branch
from
September 21, 2024 05:51
b34c9c6
to
8374e6a
Compare
hannes-ucsc
approved these changes
Sep 21, 2024
hannes-ucsc
assigned dsotirho-ucsc and hannes-ucsc and unassigned hannes-ucsc and dsotirho-ucsc
Sep 21, 2024
hannes-ucsc
changed the title
Backport: 96cd562 (#6344, PR #6585) (#6347, PR #6589)
Backport: 96cd562 (#6344, PR #6585) cb830191 (#6347, PR #6589)
Sep 21, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Author
develop
Name of PR branch matchesbackports/<7-digit SHA1 of most recent backported commit>
Author (before every review)
develop
into PR branch to integrate upstream changesmake requirements_update
or this PR does not modifyrequirements*.txt
,common.mk
,Makefile
andDockerfile
R
tag to commit title or this PR does not modifyrequirements*.txt
reqs
or does not modifyrequirements*.txt
System administrator (after approval)
no sandbox
Operator (before pushing merge the commit)
sandbox
label or PR is labeledno sandbox
dev
or PR is labeledno sandbox
anvildev
or PR is labeledno sandbox
sandbox
deployment or PR is labeledno sandbox
anvilbox
deployment or PR is labeledno sandbox
sandbox
deployment or PR is labeledno sandbox
anvilbox
deployment or PR is labeledno sandbox
p
tagsOperator (after pushing the merge commit)
dev
anvildev
dev
dev
anvildev
anvildev
dev
anvildev
Operator
Shorthand for review comments
L
line is too longW
line wrapping is wrongQ
bad quotesF
other formatting problem