Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Race condition in DockerContainerTestCase (#6587) #6594

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix: Race condition in DockerContainerTestCase (#6587) #6594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions test/docker_container_test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
from datetime import (
datetime,
)
import os
import time
from typing import (
ClassVar,
Optional,
Expand Down Expand Up @@ -75,28 +79,37 @@ def _create_container(cls, image: str, container_port: int, **kwargs) -> Netloc:
log.info('Launching %scontainer from image %s',
'sibling ' if is_sibling else '', image)
ports = None if is_sibling else {container_port: ('127.0.0.1', None)}
start = datetime.now()
container = cls._docker.containers.run(image,
detach=True,
auto_remove=True,
ports=ports,
**kwargs)
try:
container_info = cls._docker.api.inspect_container(container.id)
network_settings = container_info['NetworkSettings']
if is_sibling: # no coverage
container_ip = network_settings['IPAddress']
container_ip = container_info['NetworkSettings']['IPAddress']
assert isinstance(container_ip, str)
endpoint = (container_ip, container_port)
log.info('Launched sibling container %s from image %s, listening on %s:%i',
container.name, image, container_ip, container_port)
else:
ports = network_settings['Ports']
port = one(ports[f'{container_port}/tcp'])
while True:
seconds = (datetime.now() - start).total_seconds()
ports = container_info['NetworkSettings']['Ports'][f'{container_port}/tcp']
if len(ports) > 0:
break
elif seconds > 3:
raise RuntimeError('Unreachable TCP port', container_port, container.name)
else:
time.sleep(.33)
container_info = cls._docker.api.inspect_container(container.id)
port = one(ports)
host_ip = port['HostIp']
host_port = int(port['HostPort'])
log.info('Launched container %s from image %s, '
log.info('Launched container %s from image %s after %.3fs, '
'with container port %s mapped to %s:%i on the host',
container.name, image, container_port, host_ip, host_port)
container.name, image, seconds, container_port, host_ip, host_port)
endpoint = (host_ip, host_port)
except BaseException: # no coverage
container.kill()
Expand Down
Loading