Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2527] Create an Edit Study page #2261

Merged
merged 54 commits into from
Aug 14, 2023
Merged

[DUOS-2527] Create an Edit Study page #2261

merged 54 commits into from
Aug 14, 2023

Conversation

kaitlynoflaherty
Copy link
Contributor

@kaitlynoflaherty kaitlynoflaherty commented Jun 28, 2023

Addresses

https://broadworkbench.atlassian.net/jira/software/c/projects/DUOS/boards/123?modal=detail&selectedIssue=DUOS-2527

Summary

Note:

  1. Some of the data is corrupted in the previous studies. It is best to use a new study with all the proper info when testing

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions:

src/components/data_submission/DataAccessGovernance.js Outdated Show resolved Hide resolved
src/components/data_submission/DataAccessGovernance.js Outdated Show resolved Hide resolved
src/components/data_submission/ds_study_information.js Outdated Show resolved Hide resolved
src/pages/DataSubmissionForm.js Show resolved Hide resolved
src/pages/StudyUpdateForm.js Outdated Show resolved Hide resolved
src/pages/StudyUpdateForm.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small suggestion:

@rushtong
Copy link
Contributor

rushtong commented Aug 7, 2023

Clicking on the first option in NIH and AnVIL Use:

Screenshot 2023-08-07 at 9 40 09 AM

Should trigger the expanded view with additional questions for that section as well as NIH Administrative Information and NIH Data Management & Sharing Policy Details sections.

Update: It looks like the first three options are not showing their expanded states correctly, just the last one.

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 I think we should merge this and then do a bug session once DataBiosphere/consent#2119 is merged

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final questions / recommendations:

src/utils/JsonSchemaUtils.js Outdated Show resolved Hide resolved
src/pages/StudyUpdateForm.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I caught another small issue:

src/pages/StudyUpdateForm.js Outdated Show resolved Hide resolved
Co-authored-by: fboulnois <fboulnois@users.noreply.github.com>
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, thanks for your diligence on this ticket!

@kaitlynoflaherty kaitlynoflaherty merged commit 3ffa4e3 into develop Aug 14, 2023
10 checks passed
@kaitlynoflaherty kaitlynoflaherty deleted the duos-2527 branch August 14, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants