[DUOS-2452] DAC Dataset Acceptance => Public Visibility #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtong
reviewed
Aug 11, 2023
src/pages/DatasetCatalog.js
Outdated
| const openAccess = extractDatasetProp('Open Access', dataset); | ||
| if(!isNil(openAccess)){ | ||
| // if open Access is false, dac approval required | ||
| return openAccess ? dataset.study.publicVisibility : (dataset.dacApproval && dataset.study.publicVisibility); |
There was a problem hiding this comment.
study can be null, do we need null-safe traversal here?
There was a problem hiding this comment.
My thinking was since the openAccess is a property on a study, if openAccess is not null then the study must exist.
There was a problem hiding this comment.
I think that's true today, but the code doesn't enforce that currently and could be incorrect in the near future.
There was a problem hiding this comment.
Good point. Do you think that a good approach would be to just add dataset.study?.publicVisibility or do more thorough handling here?
There was a problem hiding this comment.
I think that's fine for this case.
rushtong
approved these changes
Aug 11, 2023
fboulnois
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/jira/software/c/projects/DUOS/boards/123?modal=detail&selectedIssue=DUOS-2452
Summary
A dataset should only be visible if Public Visibility is YES and it is ACCEPTED by the DAC,
unless it is an open access or external access dataset in which case it only needs Public Visibility to be set to YES.
Unless/until we migrate legacy datasets to have studies we rely on the Active dataset prop
Have you read Terra's Contributing Guide lately? If not, do that first.