Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-332] user.ts unit tests #2610

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Conversation

sjkobori
Copy link
Contributor

@sjkobori sjkobori commented Jun 25, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-332

Summary

Standalone PR for User.ts unit tests. Pulled out of #2557

Notes

Currently, these tests pass on local and not on GitHub actions.

@sjkobori sjkobori requested a review from a team as a code owner June 25, 2024 02:50
@sjkobori sjkobori requested review from rushtong and aarohinadkarni and removed request for a team June 25, 2024 02:50
@rushtong
Copy link
Contributor

@sjkobori - Can we move this to draft until the test failure is worked out?

@sjkobori
Copy link
Contributor Author

@sjkobori - Can we move this to draft until the test failure is worked out?

That's fine. With that in mind, are we comfortable merging in #2557 since those changes in isolation work as expected.

@sjkobori sjkobori marked this pull request as draft June 27, 2024 20:01
@rushtong
Copy link
Contributor

@sjkobori - Can we move this to draft until the test failure is worked out?

That's fine. With that in mind, are we comfortable merging in #2557 since those changes in isolation work as expected.

It looks like that PR has two approvals, so yes, please go ahead with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants