Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-47] UI: Enable DAA Restriction in Data Library #2636

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

aarohinadkarni
Copy link
Contributor

@aarohinadkarni aarohinadkarni commented Jul 25, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-47

Summary

Adds a modal that shows which of the selected datasets in the Data Library that the user creating a DAR for has approval to request access to before proceeding to the DAR. This is only enabled in dev & staging, and the original user journey remains in place in prod.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@aarohinadkarni aarohinadkarni marked this pull request as ready for review July 25, 2024 20:10
@aarohinadkarni aarohinadkarni requested a review from a team as a code owner July 25, 2024 20:10
@aarohinadkarni aarohinadkarni requested review from rushtong and okotsopoulos and removed request for a team July 25, 2024 20:10
@rushtong rushtong marked this pull request as draft July 29, 2024 14:03
@rushtong
Copy link
Contributor

Moving this back into draft today, we need to address one more design comment:

what needs to be added to the modal PR for if the user has access to none of the datasets selected:

Hi - Modal will display the message that they do not have access to those dataset and need to send request to SO. The example of the model with two columns would have the text you need. (message from Lou if you have any questions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants