Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-605: Update axios from 1.7.2->1.7.4 #2644

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Aug 13, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-605

Summary

Minor dependency update to address https://github.com/DataBiosphere/duos-ui/security/dependabot/79
See also: https://github.com/axios/axios/releases/tag/v1.7.4


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong added dependency Dependencies security Pull requests that address a security vulnerability npm labels Aug 13, 2024
@rushtong rushtong marked this pull request as ready for review August 13, 2024 19:39
@rushtong rushtong requested a review from a team as a code owner August 13, 2024 19:39
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team August 13, 2024 19:39
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad they put up a fix! (I'd guess that Dependabot would raise this PR on its own soon, but no harm in beating the 🤖 to the punch.)

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fboulnois fboulnois merged commit 519def3 into develop Aug 14, 2024
9 checks passed
@fboulnois fboulnois deleted the gr-DCJ-605-axios1.7.2->1.7.4 branch August 14, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependencies npm security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants