Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-654: Standardize metrics token usage #2668

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Sep 9, 2024

Addresses

Partially addresses https://broadworkbench.atlassian.net/browse/DCJ-654

Summary

This PR pulls out a small part of #2611 to consolidate how we're getting the access token for Metrics (bard) ajax requests. This will simplify the full B2C sign-in PR here: #2667

Drive-by fixes:

  • Typo in acknowledgements.js
  • Unused getFeatureFlag function
  • Unused fileOpts function
  • Unused fileBody function
  • Reformatted with eslint

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner September 9, 2024 17:51
@rushtong rushtong requested review from fboulnois and removed request for a team September 9, 2024 17:51
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@rushtong rushtong merged commit da48cf9 into develop Sep 10, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-654-standardize-metrics branch September 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants