Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dt-741] Fix default value for exportable datasets #2694

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

s-rubenstein
Copy link
Contributor

Addresses

Fixes the default value for exportableDatasets to be an empty object so we don't error out before getting snapshots - we just can't export till we do. (Ideally we would have a loading spinner, but since this isn't the long term home for export I figured this was a good low effort fix)

Summary


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@s-rubenstein s-rubenstein requested a review from a team as a code owner October 23, 2024 18:08
@s-rubenstein s-rubenstein requested review from snf2ye and rjohanek and removed request for a team October 23, 2024 18:08
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s-rubenstein s-rubenstein merged commit 05ce2a8 into develop Oct 23, 2024
9 checks passed
@s-rubenstein s-rubenstein deleted the sr/dt-741-fix-dataset-ajax-issue branch October 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants