Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-936] Ensure H3 validation fields have correct styling #2699

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-936

Summary

Previously, form fields that were used at the H3 level inherited the default form field styling which lead to inconsistencies in the DAR form styling. I added an optional titleStyle field that will allow a developer to set any styling on the title part of the form field so it can match the rest of the styling of the page. This leads to a consistent looking DAR page:

Screenshot 2024-10-28 at 13-30-43 Broad Data Use Oversight System


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner October 28, 2024 17:43
@fboulnois fboulnois requested review from pshapiro4broad and rjohanek and removed request for a team October 28, 2024 17:43
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏽

@fboulnois fboulnois merged commit eaa6e31 into develop Oct 29, 2024
8 checks passed
@fboulnois fboulnois deleted the fb-dt-936-fix-dar-font-sizes branch October 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants