[DT-899] Disable checkmarks and add tooltips for open or external datasets #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
rushtong and
cinyecai
and removed request for
a team
rjohanek
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
with the commented out code in DatasetSearchTableConstants removed. tool tip text looks good. Overall, I am wondering if this is really a better user experience though? after selection, when access is applied for, the information for each dataset could be given then, instead of here in tooltips. I just wonder if this is the right way to display this information. But, as an incremental improvement I think it makes sense.
rushtong
reviewed
Oct 29, 2024
| sortable: false, | ||
| cellStyle: makeHeaderStyle(studyCellWidths.selected), | ||
| cellDataFn: datasets => { | ||
| const studyDatasetIds = datasets.map(dataset => dataset.datasetId); | ||
| const numberSelected = _.intersection(studyDatasetIds, selected).length; | ||
| const fullySelected = numberSelected === studyDatasetIds.length; | ||
| const indeterminate = numberSelected > 0 && numberSelected < studyDatasetIds.length; | ||
| const checkboxId = `${datasets[0].study.studyId}-is-selected-checkbox`; | ||
| const isSelectableStudy = datasets.filter(isSelectable).length === datasets.length; | ||
| const tooltipText = 'This study contains some open or external datasets. Please select to apply for access on the individual dataset level.'; |
There was a problem hiding this comment.
The language here threw me for a loop at first. I would suggest something more like ...
This study contains some open or external datasets. Select the 'View By Datasets' tab to apply for access to 'Controlled Access' datasets in this study.
rushtong
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Disables open and external datasets, and studies which include at least one open or external dataset. Adds tooltips for these cases.
Summary
Screen.Recording.2024-10-28.at.1.57.11.PM.mov
Have you read Terra's Contributing Guide lately? If not, do that first.