[DT-900] Get search working again #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
force-pushed
the
fb-dt-900-fix-data-library-search
branch
from
d394bdd
to
c790330
Compare
cinyecai
reviewed
Oct 30, 2024
| const searchModifier = [ | ||
| { | ||
| 'multi_match': { | ||
| 'query': searchTerm, | ||
| 'query': filters.search[filters.search.length - 1], |
There was a problem hiding this comment.
Why this change if searchTerm is being set in filterHandler?
There was a problem hiding this comment.
For reasons I don't completely understand searchTerm at this line reflects the previous searchTerm state (for example if your current input was hello, searchTerm would be hell)
There was a problem hiding this comment.
I'm wondering if something similar could be done everywhere searchTerm is used to eliminate the need for that variable at all - not sure if that would work right though
fboulnois
force-pushed
the
fb-dt-900-fix-data-library-search
branch
from
c790330
to
3a21303
Compare
fboulnois
force-pushed
the
fb-dt-900-fix-data-library-search
branch
from
3a21303
to
58a5d3f
Compare
fboulnois
requested review from
rushtong and
snf2ye
and removed request for
a team
snf2ye
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-900
Summary
Fixes the search bar, and ensure that it works properly with any combination of filters and when clearing the search.
To do this the
searchRefwas removed and the search input is treated as if it was any other filter. The only difference is that the input changes must also be reflected to the user, so we need to set the state when the user types or clears the filters.Have you read Terra's Contributing Guide lately? If not, do that first.