[DT-778] Filter by Data Access Committee #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
requested review from
rushtong and
s-rubenstein
and removed request for
a team
fboulnois
commented
Nov 7, 2024
|
|
||
| export const DatasetFilterList = (props) => { | ||
| const { datasets, filters, filterHandler, isFiltered } = props; | ||
|
|
||
| const accessManagementFilters = uniq(compact(datasets.map((dataset) => dataset.accessManagement))); | ||
| const dataUseFilters = uniq(compact(flatten(datasets.map((dataset) => dataset.dataUse?.primary))).map((dataUse) => dataUse.code)); | ||
| const dacFilters = orderBy(uniq(compact(datasets.map((dataset) => dataset?.dac?.dacName))), (dac) => dac.toLowerCase(), 'asc'); |
There was a problem hiding this comment.
this does a case-ignore sort
rushtong
approved these changes
Nov 8, 2024
pshapiro4broad
approved these changes
Nov 8, 2024
| @@ -64,6 +65,27 @@ export const DatasetFilterList = (props) => { | |||
| }) | |||
| } | |||
| </List> | |||
| <Typography variant="h6" gutterBottom component="div" sx={{ fontFamily: 'Montserrat' }} marginTop="1em"> | |||
There was a problem hiding this comment.
Could these elements be refactored to avoid code duplication? They look pretty similar to me.
There was a problem hiding this comment.
I definitely want to do this long term, let me see how much work it would be.
There was a problem hiding this comment.
It wasn't too challenging, I created two new components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-778
Summary
Adds a filter for the Data Access Committee
Screen.Recording.2024-11-07.at.4.40.07.PM.mov
Have you read Terra's Contributing Guide lately? If not, do that first.