AJ-1550: bump listener image and chart

[davidangb]

Jira ticket: https://broadworkbench.atlassian.net/browse/AJ-1550

Summary of changes

• Bump TARL image to ae653801bfdbc289b48e3255aac9a7e05fa9879f
• Bump TARL chart to listener-0.3.0

What

The TARL image and chart bumps aim to allow k8s to restart TARL in cases where it runs into a problem starting and attaching to Relay, such as when it encounters a DNS timeout.

The PRs included in this bump are:

1. https://github.com/broadinstitute/terra-helmfile/pull/4992
2. AJ-1550: logging and health check for HybridConnectionListener terra-azure-relay-listeners#56
3. AJ-1550: handle errors during startup terra-azure-relay-listeners#57

as well as two PRs which should have no impact on runtime:

1. docs: add CONTRIBUTING.md info for leonardo update terra-azure-relay-listeners#53
2. build(IA-4442): enforce spotless check in CI terra-azure-relay-listeners#54

Why

In practice, we've seen recurring e2e test failures which, on the surface, look like WDS failed to start within the test's allowed 10 minutes. Upon digging in, we found that in every failure (15+), WDS started fine but the listener did not, and thus nothing could actually communicate with WDS. This problem likely occurs in production, too.

Allowing k8s to restart the listener pod if it hits an error will hopefully reduce the occurrence of this problem.

Testing these changes

What to test

• will we see a reduction in "WDS failed to start" errors in e2e tests over time?

Who tested and where

• This change is covered by automated tests
  • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
• I validated this change
• Primary reviewer validated this change
• I validated this change in the dev environment

[davidangb]

Test Result (7 failures / +6)
org.broadinstitute.dsde.workbench.leonardo.notebooks.NotebookRKernelSpec.NotebookRKernelSpec should start up an r image and have utf encoding set up
org.broadinstitute.dsde.workbench.leonardo.rstudio.RStudioSpec.RStudioSpec environment variables should be available in RStudio
org.broadinstitute.dsde.workbench.leonardo.runtimes.RuntimeCreationDiskSpec.create runtime and mount disk correctly
org.broadinstitute.dsde.workbench.leonardo.runtimes.RuntimeCreationDiskSpec.create runtime and attach an existing persistent disk or clone
org.broadinstitute.dsde.workbench.leonardo.runtimes.RuntimeSystemSpec.RuntimeSystemSpec should have the workspace-related environment variables set in jupyter image
org.broadinstitute.dsde.workbench.leonardo.runtimes.RuntimeSystemSpec.RuntimeSystemSpec should have Java available

Jenkins retest.

[davidangb]

Test Result (7 failures / +2)
org.broadinstitute.dsde.workbench.leonardo.apps.AppLifecycleSpec.create CROMWELL app, delete it and re-create it with same disk
org.broadinstitute.dsde.workbench.leonardo.apps.AppLifecycleSpec.create RSTUDIO app, delete it and re-create it with same disk
org.broadinstitute.dsde.workbench.leonardo.apps.AppLifecycleSpec.create CUSTOM app then delete it
org.broadinstitute.dsde.workbench.leonardo.notebooks.NotebookRKernelSpec.NotebookRKernelSpec should start up an r image and have utf encoding set up
org.broadinstitute.dsde.workbench.leonardo.rstudio.RStudioSpec.RStudioSpec environment variables should be available in RStudio
org.broadinstitute.dsde.workbench.leonardo.runtimes.RuntimeCreationDiskSpec.create runtime and attach an existing persistent disk or clone
org.broadinstitute.dsde.workbench.leonardo.notebooks.NotebookGCECustomizationSpec.NotebookGCECustomizationSpec should populate user-specified environment variables

Jenkins retest.

[davidangb]

Test Result (3 failures / +3)
org.broadinstitute.dsde.workbench.leonardo.notebooks.NotebookRKernelSpec.NotebookRKernelSpec should start up an r image and have utf encoding set up
org.broadinstitute.dsde.workbench.leonardo.rstudio.RStudioSpec.RStudioSpec environment variables should be available in RStudio
org.broadinstitute.dsde.workbench.leonardo.runtimes.RuntimeCreationDiskSpec.create runtime and attach an existing persistent disk or clone

Jenkins retest, but noting that these three tests have failed in all of my runs. Is it possible they're valid failures?

[davidangb]

fiab-start failure. Jenkins retest.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (493abbc) 71.32% compared to head (07e1c9b) 71.32%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4154   +/-   ##
========================================
  Coverage    71.32%   71.32%           
========================================
  Files          147      147           
  Lines        13913    13913           
  Branches      1110     1110           
========================================
  Hits          9923     9923           
  Misses        3990     3990           

Flag	Coverage Δ
pact	48.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493abbc...07e1c9b. Read the comment docs.