Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-4808] Specify jupyter and welder user IDs #4464

Closed
wants to merge 1 commit into from
Closed

Conversation

lucymcnatt
Copy link
Collaborator

@lucymcnatt lucymcnatt commented Apr 22, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4808

Dependencies

DataBiosphere/welder#269
DataBiosphere/terra-docker#487

Summary of changes

What

  • Updates the jupyter user id in the azure init script
  • Updates the welder version
  • Incorporates the new docker images (had to update the base image to change the welder uid)

Why

  • the user IDs after 1000 are reserved for 'normal' (non-system) users and they normally get assigned sequentially.
  • In order to avoid the case where 1001 is already assigned to a different user, this moves the uid into the 2000s.
  • A new user was added via the Azure DSVM that bumped the sequence of UIDs back, so 1001 was taken by the leoAdmin user and that caused permission issues for the /work folder welder depends on

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (45e175d) to head (9845e80).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4464   +/-   ##
========================================
  Coverage    73.69%   73.69%           
========================================
  Files          157      157           
  Lines        14631    14631           
  Branches      1175     1175           
========================================
  Hits         10782    10782           
  Misses        3849     3849           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e175d...9845e80. Read the comment docs.

@lucymcnatt lucymcnatt changed the title [IA-4808] Specify jupyter user ID [IA-4808] Specify jupyter and welder user IDs Apr 23, 2024
@lucymcnatt lucymcnatt closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant