-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RW-12298] upgrade AoU docker images #4490
Conversation
welder_server="us.gcr.io/broad-dsp-gcr-public/welder-server:8667bfe" | ||
openidc_proxy="broadinstitute/openidc-proxy:2.3.1_2" | ||
anvil_rstudio_bioconductor="us.gcr.io/broad-dsp-gcr-public/anvil-rstudio-bioconductor:3.18.0" | ||
|
||
# Note that this is the version used currently by AOU in production, the one above can be staged for testing | ||
terra_jupyter_aou_old="us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.7" | ||
terra_jupyter_aou_old="us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.2.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which version we have in prod today? this needs to be what's in prod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. it is 2.2.7 now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4490 +/- ##
========================================
Coverage 73.64% 73.64%
========================================
Files 158 158
Lines 14694 14694
Branches 1162 1162
========================================
Hits 10822 10822
Misses 3872 3872 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems dataproc was updated at some point https://github.com/DataBiosphere/leonardo/blob/develop/jenkins/dataproc-custom-images/prepare-custom-leonardo-jupyter-dataproc-image.sh#L24
The latest image on GCR is 2.2.9 https://console.cloud.google.com/artifacts/docker/broad-dsp-gcr-public/us/us.gcr.io/terra-jupyter-aou?project=broad-dsp-gcr-public |
just triggered rerun of all tests |
|
|
I have a feeling we might run out of disk...but can verify Mon on a BEE |
For image size, seems not a big increase
|
FYI @yonghaoy and @Qi77Qi I am taking a stab at updating the docker images again with a new bioconductor release and I will try to debug this while I am at it, I will keep you posted DataBiosphere/terra-docker#488 |
thanks @LizBaldo ! |
Got it, the only thing that I remember doing back in March is fixing the AOU image this way. I do not think that would cause issues with restarting but I thought I would still share DataBiosphere/terra-docker#476 |
I will just point my BEE to this branch and see if I can create an AOU runtime and ssh into it |
Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retest
orjenkins multi-test
.