Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1550: handle errors during startup #57

Merged
merged 3 commits into from
Jan 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove redundant lines in test
  • Loading branch information
davidangb committed Jan 26, 2024
commit 33d9ea250cb329b3e6b24361f97e9714751e0401
Original file line number Diff line number Diff line change
@@ -152,8 +152,6 @@ void processRelayedRequestsError() throws Exception {
"Liveness state should be CORRECT",
applicationAvailability.getLivenessState(),
equalTo(LivenessState.CORRECT));
ResultActions result = mvc.perform(get("/actuator/health/liveness"));
result.andExpect(status().isOk()).andExpect(jsonPath("$.status").value("UP"));
ResultActions livenessResult = mvc.perform(get("/actuator/health/liveness"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this liveness probe called twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of a copy-paste error on my part! Good catch, thank you; fixed.

livenessResult.andExpect(status().isOk()).andExpect(jsonPath("$.status").value("UP"));

Loading