Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-4760] new GHA to replace last jenkins job #493

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

LizBaldo
Copy link
Collaborator

@LizBaldo LizBaldo commented Aug 21, 2024

JIRA ticket: https://broadworkbench.atlassian.net/browse/IA-4760

Since we already have a bash script that build each image individually, I just created a new one that loops through the images to build in the correct order, and then generate the versions.json file, which effectively replaces what the Jenkins job was doing.

Not quite sure how to test this though, I might do a trigger on PR commits first to iterate and then will revert back to a push to master trigger.

- name: Build Docker image and publish
run: |
gcloud auth configure-docker
./build_all.sh
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I am choosing to not add the complexity of opening the Leo PR. It requires further manual steps already like regenerating the COS and dataproc images so it felt silly to try to do the first part automatically, especially since we want to refactor how this whole repo works next.

@LizBaldo LizBaldo requested a review from jdcanas August 21, 2024 21:20
Copy link

@mlilynolting mlilynolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Your test plan makes sense.

@LizBaldo LizBaldo merged commit cffd18a into master Aug 28, 2024
3 checks passed
@LizBaldo LizBaldo deleted the IA-4760-retire-jenkins branch August 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants