Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ID-1352] Update TNU version in Dockerfile #495

Merged
merged 21 commits into from
Sep 18, 2024

Conversation

samanehsan
Copy link
Contributor

@samanehsan samanehsan commented Sep 3, 2024

Use latest version 0.14: https://pypi.org/project/terra-notebook-utils/0.14.0/ which has the following changes

Use latest version 0.14
Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samanehsan the change looks good, but you need to bump up the version of all of the docker containers appropriately, see CONTRIBUTING.md

@LizBaldo
Copy link
Collaborator

LizBaldo commented Sep 3, 2024

Here is a previous PR updating TNU that should be a good baseline #449

@samanehsan
Copy link
Contributor Author

@LizBaldo, I made the changes you requested :octocat:

@LizBaldo
Copy link
Collaborator

LizBaldo commented Sep 4, 2024

Thanks! Let's see if the tests are passing, I can move this PR along if needed

@samanehsan
Copy link
Contributor Author

@LizBaldo there are two tests failing but I don't quite understand the errors. Could you take a look?

@LizBaldo
Copy link
Collaborator

LizBaldo commented Sep 5, 2024

Yep, I am on it and will move the PR along :)

@LizBaldo
Copy link
Collaborator

LizBaldo commented Sep 9, 2024

@samanehsan and @tlangs how critical is the release of TNU 14? As you can see, this PR is getting very unwieldy and I think it is about time that I refactor the base image first, and this whole process frankly. But that might take me a sprint or so, hence delaying the release of TNU further

@samanehsan
Copy link
Contributor Author

@LizBaldo it's not super urgent so it can wait a sprint or two. The release includes these two changes:

  1. Notebooks will tell DrsHub the cloud they are running on to cut down on unnecessary egress costs
  2. Notebooks will pass in a "service-name" header so DrsHub can show how many requests are coming from notebooks in our product metrics dashboard (requested by stakeholders)

@LizBaldo
Copy link
Collaborator

@samanehsan FYI things are looking almost ready to ship, finally :) If you don't mind giving the sister PR in Leonardo a review that would be awesome, thanks! DataBiosphere/leonardo#4784

@LizBaldo LizBaldo merged commit 33c9adc into master Sep 18, 2024
9 of 10 checks passed
@LizBaldo LizBaldo deleted the se/ID-1352-update-tnu-version branch September 18, 2024 17:15
LizBaldo added a commit that referenced this pull request Oct 30, 2024
LizBaldo added a commit that referenced this pull request Oct 31, 2024
* Revert "[ID-1352] Update TNU version in Dockerfile (#495)"

This reverts commit 33c9adc.

* keep the gha workflow updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants