Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-156] Enhance Feature Preview Page Visibility and Usability in Navigation #5170

Merged
merged 14 commits into from
Nov 15, 2024

Conversation

kevinmarete
Copy link
Contributor

Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-156

What

  • This PR improves the visibility and functionality of the Feature Preview page by:
    • Adding a new “📰 Platform News” section in the left-hand navigation with links to:

    • Updating the Feature Preview page with:

      • A clearer top message explaining the purpose of feature previews.
      • Toggles instead of checkboxes are used to enable/disabling features.
      • A lock icon and tooltip for private features.
      • A new “Last Updated” column with feature update dates.

Why

  • These changes help users learn about and engage with new features before release, promoting early feedback and better feature quality.

Testing strategy

  • Unit Testing: Updated unit tests to validate changes
  • Manual Testing
    • Verify the new “📰 Platform News” section appears in the navigation with working links.
    • Ensure the Feature Preview page updates (toggles, lock icon, tooltips, and “Last Updated” column) work as intended.

Platform News Menu
Platform News Menu

Feature Preview Page
Feature Preview Page

@kevinmarete kevinmarete requested a review from a team November 15, 2024 06:54
@kevinmarete kevinmarete self-assigned this Nov 15, 2024
@kevinmarete kevinmarete requested review from dvoet and calypsomatic and removed request for a team November 15, 2024 06:54
@admull
Copy link

admull commented Nov 15, 2024

Please swap the Platform News and Support sections in the lefthand navigation. Everything else looks great!

@@ -112,6 +124,7 @@ const featurePreviewsConfig: readonly FeaturePreview[] = [
feedbackUrl: `mailto:dsp-core-services@broadinstitute.org?subject=${encodeURIComponent(
'Feedback on Improved Spend Reports'
)}`,
lastUpdated: '11/19/2024',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to know that these need to be updated if these things change? It seems like the sort of thing that will quickly be inaccurate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@admull can you take this one?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we should have a shared responsibility to remember to update this if we wind up making updates to the feature while it's in preview. I'm happy for product to own responsibility but would appreciate reminders from time to time 😄.

Copy link
Contributor

@calypsomatic calypsomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I scanned the feature-preview page with axe devtools, a couple of issues came up that aren't there on production. Could you take a look and see if you could resolve any of them?

@kevinmarete
Copy link
Contributor Author

Please swap the Platform News and Support sections in the lefthand navigation. Everything else looks great!

Done: da66dcfe8b28c50b284dbed766ccfd9085731c10

Swapped menus

@kevinmarete
Copy link
Contributor Author

When I scanned the feature-preview page with axe devtools, a couple of issues came up that aren't there on production. Could you take a look and see if you could resolve any of them?

Fixed: 4695ca1

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Contributor

@calypsomatic calypsomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@kevinmarete kevinmarete added this pull request to the merge queue Nov 15, 2024
Merged via the queue into dev with commit b8baa5b Nov 15, 2024
10 checks passed
@kevinmarete kevinmarete deleted the km_CORE-156_update_feature_preview branch November 15, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants