-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-156] Enhance Feature Preview Page Visibility and Usability in Navigation #5170
Conversation
Please swap the Platform News and Support sections in the lefthand navigation. Everything else looks great! |
@@ -112,6 +124,7 @@ const featurePreviewsConfig: readonly FeaturePreview[] = [ | |||
feedbackUrl: `mailto:dsp-core-services@broadinstitute.org?subject=${encodeURIComponent( | |||
'Feedback on Improved Spend Reports' | |||
)}`, | |||
lastUpdated: '11/19/2024', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to know that these need to be updated if these things change? It seems like the sort of thing that will quickly be inaccurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@admull can you take this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we should have a shared responsibility to remember to update this if we wind up making updates to the feature while it's in preview. I'm happy for product to own responsibility but would appreciate reminders from time to time 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I scanned the feature-preview page with axe devtools, a couple of issues came up that aren't there on production. Could you take a look and see if you could resolve any of them?
Done: da66dcfe8b28c50b284dbed766ccfd9085731c10 |
Fixed: 4695ca1 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-156
What
Adding a new “📰 Platform News” section in the left-hand navigation with links to:
Updating the Feature Preview page with:
Why
Testing strategy
Platform News Menu
Feature Preview Page