Final code push, added log that saves locally, improved duplicate handling#202
Open
JetRam wants to merge 11 commits intoDataBytes-Organisation:mainfrom
Open
Final code push, added log that saves locally, improved duplicate handling#202JetRam wants to merge 11 commits intoDataBytes-Organisation:mainfrom
JetRam wants to merge 11 commits intoDataBytes-Organisation:mainfrom
Conversation
…port_csv to save to Mongodb
…th Shishir's help
Signed-off-by: shishirdhakal123 <109933500+shishirdhakal123@users.noreply.github.com>
Collaborator
|
Resolved merge conflicts. |
Comment on lines
+6
to
+8
| client = MongoClient( | ||
| 'mongodb+srv://discountmate_read_and_write:discountmate@discountmatecluster.u80y7ta.mongodb.net/?retryWrites=true&w=majority&appName=DiscountMateCluster' | ||
| ) |
Collaborator
There was a problem hiding this comment.
Sensitive credentials are exoposed. Please use environment variables instead of hardcoding username and password in the connection string.
Comment on lines
+19
to
+20
| def setup_mongo(): | ||
| client = MongoClient("mongodb+srv://discountmate_read_and_write:discountmate@discountmatecluster.u80y7ta.mongodb.net/?retryWrites=true&w=majority&appName=DiscountMateCluster") |
Collaborator
There was a problem hiding this comment.
Sensitive credentials are exoposed. Please use environment variables instead of hardcoding username and password in the connection string.
| sys.exit() | ||
|
|
||
| # MongoDB database and collection | ||
| client = MongoClient("mongodb+srv://discountmate_read_and_write:discountmate@discountmatecluster.u80y7ta.mongodb.net/?retryWrites=true&w=majority&appName=DiscountMateCluster") |
Collaborator
There was a problem hiding this comment.
Sensitive credentials are exoposed. Please use environment variables instead of hardcoding username and password in the connection string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.