Hide/Show_Password_Feature_html_Login_page

[SaadAli100]

PR Template

Any italic text should be deleted from the final Pull Request text, including this line

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Testing Checklist

• Tested in latest Chrome
• Tested in latest Safari
• Tested in latest Firefox

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have requested a review from NAMES HERE on the Pull Request

Notes for PRs

Below the commit message field you decide whether you are committing your changes to the current branch or a new branch. If the current brain is the main branch (develop), commit to a new branch.

Filling In CheckBox Example

• Example Filled
• Example Empty

[hmm007]

Your change of lines 29 and 30 are unnecessary

By changing line 30 you remove our new Login functionality - which enables users to log in via email, rather than by username.

Lines 32 and 33 are the only ones relevant to your code.

Line 40 created the reset password page functionality - where users clicking 'Forgot Password' would be redirected to the reset password page.

There are no issues with line 123, it seems you moved it down.

As for the hide/show password functionality - it doesn't work. See recording attached. I think your addeventlistener code in the .js files need to be looked at.

hide-show-function-fail-test-loginpage.mp4