Skip to content

Hide/Show_Password_Feature_registrator_html#305

Open
SaadAli100 wants to merge 1 commit intodevelopfrom
Hide/Show_Password_Feature_registrator_html
Open

Hide/Show_Password_Feature_registrator_html#305
SaadAli100 wants to merge 1 commit intodevelopfrom
Hide/Show_Password_Feature_registrator_html

Conversation

@SaadAli100
Copy link
Contributor

@SaadAli100 SaadAli100 commented May 16, 2024

PR Template

Any italic text should be deleted from the final Pull Request text, including this line

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from NAMES HERE on the Pull Request

Notes for PRs

Below the commit message field you decide whether you are committing your changes to the current branch or a new branch. If the current brain is the main branch (develop), commit to a new branch.

Filling In CheckBox Example

  • Example Filled
  • Example Empty

Signed-off-by: SaadAli100 <150887259+SaadAli100@users.noreply.github.com>
Copy link
Collaborator

@hmm007 hmm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the code looks sound, and it's clear which lines relate specifically to your feature - the code doesn't function. It has also removed the previous functionalities: the password complexity requirement feature no longer appears, and it appears you've removed the comment including the basis of your CAPTCHA requirement.

hide-show-function-fail-test.mp4

I suggest making the functionalities work, but I'm unsure if there's time left for that.

Just letting you know beforehand - the register.js and login.js files have been updated already , so it's not a case of the not up-to-date code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments