Hide/Show_Password_Feature_registrator_html#305
Open
SaadAli100 wants to merge 1 commit intodevelopfrom
Open
Conversation
Signed-off-by: SaadAli100 <150887259+SaadAli100@users.noreply.github.com>
hmm007
requested changes
May 16, 2024
Collaborator
hmm007
left a comment
There was a problem hiding this comment.
While the code looks sound, and it's clear which lines relate specifically to your feature - the code doesn't function. It has also removed the previous functionalities: the password complexity requirement feature no longer appears, and it appears you've removed the comment including the basis of your CAPTCHA requirement.
hide-show-function-fail-test.mp4
I suggest making the functionalities work, but I'm unsure if there's time left for that.
Just letting you know beforehand - the register.js and login.js files have been updated already , so it's not a case of the not up-to-date code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Template
Any italic text should be deleted from the final Pull Request text, including this line
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Testing Checklist
Checklist
Notes for PRs
Below the commit message field you decide whether you are committing your changes to the current branch or a new branch. If the current brain is the main branch (develop), commit to a new branch.
Filling In CheckBox Example