Fix interactive mod (#210)

* fix * refactor * fixing default conf for system tests
DataDog · Jun 21, 2024 · 9e4e192 · 9e4e192
1 parent dece49a
commit 9e4e192
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/pkg/cmd/util.go b/pkg/cmd/util.go
@@ -12,7 +12,7 @@ func AskForConfirmation() (bool, error) {
 	var response string
 
 	_, err := fmt.Scanln(&response)
-	if err.Error() != "unexpected newline" {
+	if err != nil && err.Error() != "unexpected newline" {
 		return false, fmt.Errorf("scanln: %w", err)
 	}
 

diff --git a/pkg/ingestor/puller/puller_test.go b/pkg/ingestor/puller/puller_test.go
@@ -130,7 +130,8 @@ func TestExtractTarGz(t *testing.T) {
 			if err != nil {
 				t.Error(err)
 			}
-			if err := ExtractTarGz(false, "./testdata/archive.tar.gz", tmpPath, tt.args.maxArchiveSize); (err != nil) != tt.wantErr {
+			dryRun := false
+			if err := ExtractTarGz(dryRun, "./testdata/archive.tar.gz", tmpPath, tt.args.maxArchiveSize); (err != nil) != tt.wantErr {
 				t.Errorf("ExtractTarGz() error = %v, wantErr %v", err, tt.wantErr)
 			}
 			for _, file := range tt.expectedFiles {

diff --git a/test/system/kubehound_dump.yaml b/test/system/kubehound_dump.yaml
@@ -33,7 +33,7 @@ ingestor:
     region: "" # (i.e.: us-west-2)
   temp_dir: "/tmp/kubehound"
   archive_name: "archive.tar.gz"
-  max_archive_size: 1073741824 # 1GB
+  max_archive_size: 2147483648 # 2GB
   api: # GRPC endpoint for the ingestor
     endpoint: "127.0.0.1:9000"
     insecure: true