Support feature flags in the CI #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinFairise2
changed the title
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
3 times, most recently
from
536a5fc to
d7a0c79
Compare
KevinFairise2
force-pushed
the
kfairise/support-feature-flag-ci
branch
25 times, most recently
from
4355fe1 to
3dea7c7
Compare
KevinFairise2
force-pushed
the
kfairise/support-feature-flag-ci
branch
3 times, most recently
from
f0dcb5e to
be7a4ee
Compare
KevinFairise2
force-pushed
the
kfairise/feature-flags-dda
branch
2 times, most recently
from
a7a0f61 to
fa3cd53
Compare
KevinFairise2
force-pushed
the
kfairise/support-feature-flag-ci
branch
5 times, most recently
from
c875cc7 to
7efa4d7
Compare
KevinFairise2
force-pushed
the
kfairise/support-feature-flag-ci
branch
from
7efa4d7 to
2d11958
Compare
KevinFairise2
force-pushed
the
kfairise/support-feature-flag-ci
branch
2 times, most recently
from
34ae8dd to
401a746
Compare
chouetz
approved these changes
Nov 7, 2025
| from dda.feature_flags.manager import FeatureFlagManager | ||
|
|
||
| return FeatureFlagManager(self) | ||
| self.display_info(f"IS IT RUNNING IN CI {running_in_ci()}") |
Member
There was a problem hiding this comment.
Suggested change
| self.display_info(f"IS IT RUNNING IN CI {running_in_ci()}") | |
| self.display_info(f"Is it running in CI {running_in_ci()}") |
🥜 the capital letters seems aggressive
| @@ -0,0 +1,6 @@ | |||
| def fetch_secret_ssm(name: str) -> str: | |||
Member
There was a problem hiding this comment.
Suggested change
| def fetch_secret_ssm(name: str) -> str: | |
| def fetch_secret(name: str) -> str: |
As it's in the ssm namespace I guess it's ok. Just to align on the naming from the vault module
| DDA_FEATURE_FLAGS_CI_VAULT_KEY: CLIENT_TOKEN | ||
| DDA_FEATURE_FLAGS_CI_VAULT_PATH_MACOS: kv/path/to/dda/feature-flags | ||
| DDA_FEATURE_FLAGS_CI_VAULT_KEY_MACOS: CLIENT_TOKEN | ||
| DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS: my/ssm/parameter/name |
Member
There was a problem hiding this comment.
Suggested change
| DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS: my/ssm/parameter/name | |
| DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS: ci.repo-name.my-ssm-parameter-name |
🥜 but I think the naming is important for the ssm param to be retrieved correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
LocalFeatureFlagManagervsCIFeatureFlagManager, these are two different subclasses because they are quite different in the way they retrieve secrets, and the context they provide.Also add some documentation about how to use feature flags in actual
ddacode.Using the feature flag in the CI expect you to pass some keys as environment variable. As the way the secrets can be retrieved is not the same on the different OSes and that the parameter name can be different, you need the following environment variables in
.gitlab-ci.yamlto configure token retrieval for dda features flagsDDA_FEATURE_FLAGS_CI_VAULT_KEYDDA_FEATURE_FLAGS_CI_VAULT_PATHDDA_FEATURE_FLAGS_CI_VAULT_KEY_MACOSDDA_FEATURE_FLAGS_CI_VAULT_PATH_MACOSDDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWSExample of jobs running with that on datadog-agent side: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1184492696