APM: Add top level support for span events (AIDM-403) #32479
Conversation
github-actions
bot
added
team/agent-apm
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=52584162 --os-family=ubuntuNote: This applies to commit 53336ad |
ajgajg1134
changed the title
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 16238ca Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.72 | [+1.03, +2.41] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.72 | [+0.60, +0.84] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.48 | [+0.34, +0.62] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.40 | [+0.31, +0.49] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.18 | [+0.14, +0.22] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.08 | [-0.78, +0.95] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.08 | [-0.38, +0.55] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.05 | [-0.73, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.65] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.76, +0.78] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.12, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.73, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.08 | [-0.82, +0.66] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.13 | [-0.93, +0.67] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -4.53 | [-7.69, -1.37] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
ajgajg1134
added
the
qa/done
|
/merge |
Devflow running:
|
What does this PR do?
Adds span events to the proto and message pack data formats for a span. Tracers can detect support for this new feature via the /info endpoint and new field
span_eventswhich will be set totrue. See RFC for more details.Motivation
This allows us to properly handle span events with a fully typed field, deprecating previous work-around methods that had issues related to tag size limits.
Additionally this change treats these span events more consistently: e.g. Span Event attributes will have replace_tags configuration applied to them, have stacktraces removed (when enabled), and have possible credit cards obfuscated (when enabled)
Describe how you validated your changes
I have unit and integration tests here that verify the support of span events
Possible Drawbacks / Trade-offs
To maintain consistency with how stack trace obfuscation is enabled today this change also introduces a minor change to obfuscation outside of span events: The tag
exception.stacktracewill now also be redacted when apm_config.obfuscation.remove_stack_traces is set to true.Additional Notes