[BARX-713] Add dev image tagged with commit #32501

AliDatadog · 2024-12-24T12:12:33Z

What does this PR do?

This PR adds a manual job to deploy a dev image tagged with a short commit sha.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-12-24T12:13:43Z

Gitlab CI Configuration Changes

Modified Jobs

dev_branch_multiarch-a7

  dev_branch_multiarch-a7:
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - docker_build_agent7
    - docker_build_agent7_arm64
    - docker_build_agent7_jmx
    - docker_build_agent7_jmx_arm64
    parallel:
      matrix:
      - IMG_DESTINATIONS: agent-dev:${CI_COMMIT_REF_SLUG}-py3
        IMG_SOURCES: ${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-amd64,${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-arm64
      - IMG_DESTINATIONS: agent-dev:${CI_COMMIT_REF_SLUG}-py3-jmx
+       IMG_SOURCES: ${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-amd64,${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-arm64
+     - IMG_DESTINATIONS: agent-dev:${CI_COMMIT_SHORT_SHA}-py3-jmx
        IMG_SOURCES: ${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-amd64,${SRC_AGENT}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}-7-jmx-arm64
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - GITLAB_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $GITLAB_TOKEN write_api)
      || exit $?; export GITLAB_TOKEN
    - "if [[ \"$BUCKET_BRANCH\" == \"nightly\" && ( \"$IMG_SOURCES\" =~ \"$SRC_AGENT\"\
      \ || \"$IMG_SOURCES\" =~ \"$SRC_DCA\" || \"$IMG_SOURCES\" =~ \"$SRC_CWS_INSTRUMENTATION\"\
      \ || \"$IMG_VARIABLES\" =~ \"$SRC_AGENT\" || \"$IMG_VARIABLES\" =~ \"$SRC_DCA\"\
      \ || \"$IMG_VARIABLES\" =~ \"$SRC_CWS_INSTRUMENTATION\" ) ]]; then\n  export ECR_RELEASE_SUFFIX=\"\
      -nightly\"\nelse\n  export ECR_RELEASE_SUFFIX=\"${CI_COMMIT_TAG+-release}\"\n\
      fi\n"
    - IMG_VARIABLES="$(sed -E "s#(${SRC_AGENT}|${SRC_DSD}|${SRC_DCA}|${SRC_CWS_INSTRUMENTATION})#\1${ECR_RELEASE_SUFFIX}#g"
      <<<"$IMG_VARIABLES")"
    - IMG_SOURCES="$(sed -E "s#(${SRC_AGENT}|${SRC_DSD}|${SRC_DCA}|${SRC_CWS_INSTRUMENTATION})#\1${ECR_RELEASE_SUFFIX}#g"
      <<<"$IMG_SOURCES")"
    - inv pipeline.trigger-child-pipeline --project-name DataDog/public-images --git-ref
      main --timeout 1800 --variable IMG_VARIABLES --variable IMG_REGISTRIES --variable
      IMG_SOURCES --variable IMG_DESTINATIONS --variable IMG_SIGNING --variable APPS
      --variable BAZEL_TARGET --variable DDR --variable DDR_WORKFLOW_ID --variable TARGET_ENV
      --variable DYNAMIC_BUILD_RENDER_TARGET_FORWARD_PARAMETERS
    stage: dev_container_deploy
    tags:
    - arch:amd64
    variables:
      IMG_REGISTRIES: dev
      IMG_SIGNING: ''
      IMG_VARIABLES: ''
      SRC_AGENT: registry.ddbuild.io/ci/datadog-agent/agent
      SRC_CWS_INSTRUMENTATION: registry.ddbuild.io/ci/datadog-agent/cws-instrumentation
      SRC_DCA: registry.ddbuild.io/ci/datadog-agent/cluster-agent
      SRC_DSD: registry.ddbuild.io/ci/datadog-agent/dogstatsd

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2024-12-24T12:33:18Z

[Fast Unit Tests Report]

On pipeline 51764612 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

agent-platform-auto-pr · 2024-12-24T12:36:05Z

Uncompressed package size comparison

Comparison with ancestor dbadf918107b26e1733db87a51801f0f79893ff8

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1190.70MB	1190.70MB	140.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1199.96MB	1199.96MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1199.96MB	1199.96MB	140.00MB
datadog-agent-arm64-deb	0.00MB	✅	934.99MB	934.99MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	944.24MB	944.24MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.57MB	78.57MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.65MB	78.65MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.65MB	78.65MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.77MB	55.77MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	505.11MB	505.11MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.34MB	113.34MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.41MB	113.41MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.41MB	113.41MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.81MB	108.81MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.88MB	108.88MB	10.00MB

Decision

✅ Passed

cit-pr-commenter · 2024-12-24T13:01:32Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5008533d-14c6-428b-a502-ae5aedeba27f

Baseline: dbadf91
Comparison: e2966bc
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.60	[-0.07, +1.28]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.07	[-0.84, +0.98]	1	Logs
➖	file_tree	memory utilization	+0.06	[-0.07, +0.20]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.06	[-0.03, +0.15]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.76, +0.83]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.10, +0.12]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.67, +0.70]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.65, +0.64]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.79, +0.76]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.02	[-0.91, +0.87]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.37	[-1.17, +0.43]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.60	[-1.06, -0.13]	1	Logs
➖	quality_gate_idle	memory utilization	-0.74	[-0.78, -0.70]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.92	[-4.16, +2.33]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.50	[-1.56, -1.44]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

AliDatadog · 2024-12-30T15:23:39Z

/merge

dd-devflow · 2024-12-30T15:23:49Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-30 15:23:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-30 19:23:51 UTC ⚠️ MergeQueue: This merge request was unqueued

ali.benabdallah@datadoghq.com unqueued this merge request: It did not become mergeable within the expected time

AliDatadog · 2024-12-31T09:43:10Z

/merge

dd-devflow · 2024-12-31T09:43:19Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-31 09:43:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-31 13:43:20 UTC ⚠️ MergeQueue: This merge request was unqueued

ali.benabdallah@datadoghq.com unqueued this merge request: It did not become mergeable within the expected time

AliDatadog · 2025-01-02T11:04:45Z

/merge

dd-devflow · 2025-01-02T11:04:53Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2025-01-02 11:04:53 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-02 11:06:56 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 35m.

2025-01-02 11:38:17 UTC ℹ️ MergeQueue: This merge request was merged

commit agent-dev:short_sha image

e2966bc

AliDatadog added this to the 7.62.0 milestone Dec 24, 2024

AliDatadog requested review from a team as code owners December 24, 2024 12:12

github-actions bot added team/agent-delivery short review PR is simple enough to be reviewed quickly labels Dec 24, 2024

Pythyu approved these changes Dec 24, 2024

View reviewed changes

scottopell approved these changes Dec 24, 2024

View reviewed changes

clamoriniere approved these changes Dec 31, 2024

View reviewed changes

AliDatadog added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 2, 2025

dd-mergequeue bot merged commit f054ec9 into main Jan 2, 2025
250 of 252 checks passed

dd-mergequeue bot deleted the ali/dev-image branch January 2, 2025 11:38

github-actions bot modified the milestones: 7.62.0, 7.63.0 Jan 2, 2025

mwdd146980 pushed a commit that referenced this pull request Jan 10, 2025

[BARX-713] Add dev image tagged with commit (#32501)

15b828a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BARX-713] Add dev image tagged with commit #32501

[BARX-713] Add dev image tagged with commit #32501

Uh oh!

AliDatadog commented Dec 24, 2024

Uh oh!

agent-platform-auto-pr bot commented Dec 24, 2024

Uh oh!

agent-platform-auto-pr bot commented Dec 24, 2024

Uh oh!

agent-platform-auto-pr bot commented Dec 24, 2024

Uh oh!

cit-pr-commenter bot commented Dec 24, 2024

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

AliDatadog commented Dec 30, 2024

Uh oh!

dd-devflow bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

AliDatadog commented Dec 31, 2024

Uh oh!

dd-devflow bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

AliDatadog commented Jan 2, 2025

Uh oh!

dd-devflow bot commented Jan 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[BARX-713] Add dev image tagged with commit #32501

[BARX-713] Add dev image tagged with commit #32501

Uh oh!

Conversation

AliDatadog commented Dec 24, 2024

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented Dec 24, 2024

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

Uh oh!

agent-platform-auto-pr bot commented Dec 24, 2024

Uh oh!

agent-platform-auto-pr bot commented Dec 24, 2024

Uncompressed package size comparison

Decision

Uh oh!

cit-pr-commenter bot commented Dec 24, 2024

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

AliDatadog commented Dec 30, 2024

Uh oh!

dd-devflow bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Devflow running: /merge

Uh oh!

AliDatadog commented Dec 31, 2024

Uh oh!

dd-devflow bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Devflow running: /merge

Uh oh!

AliDatadog commented Jan 2, 2025

Uh oh!

dd-devflow bot commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Devflow running: /merge

Uh oh!

Uh oh!

Uh oh!

dd-devflow bot commented Dec 30, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 31, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Jan 2, 2025 •

edited

Loading

Devflow running: `/merge`