Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More minor cleanup #10

Merged
merged 2 commits into from
Aug 23, 2023
Merged

More minor cleanup #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bdf03b
Remove ruby versioning in Appraisal
TonyCTHsu Aug 22, 2023
0910b3a
Remove rspec and cucumber depenedencies from task :main
TonyCTHsu Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,6 @@ if ["true", "y", "yes", "1"].include?(ENV["APPRAISAL_SKIP_BUNDLE_CHECK"])
::Appraisal::Appraisal.prepend(DisableBundleCheck)
end

def ruby_version?(version)
full_version = "#{version}.0" # Turn 2.1 into 2.1.0 otherwise #bump below doesn't work as expected

Gem::Version.new(full_version) <= Gem::Version.new(RUBY_VERSION) &&
Gem::Version.new(RUBY_VERSION) < Gem::Version.new(full_version).bump
end

alias original_appraise appraise

REMOVED_GEMS = {
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ end
desc "Run RSpec"
# rubocop:disable Metrics/BlockLength
namespace :spec do
task all: [:main, :cucumber, :rspec]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a dependency for task :all that it should run tests for main, cucumber, and rspec

Maybe we would rather need to add minitest here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it should include all those tasks.

However, those tasks can only been executed with proper dependencies installed (using Appraisal at this moment).

For example:
✅ bundle exec rake spec:main
🔴 bundle exec rake spec:cucumber
✅ bundle exec appraisal cucumber8 rake spec:cucumber

task all: [:main]

RSpec::Core::RakeTask.new(:main) do |t, args|
t.pattern = "spec/**/*_spec.rb"
Expand Down