Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cucumber-ruby 9.2 includes breaking change for Cucumber::Core::Test::Result #145

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: cucumber-ruby 9.2 includes breaking change for Cucumber::Core::Test::Result #145

merged 1 commit into from
Mar 19, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Fixes breaking change introduced in cucumber-ruby 9.2 here:

result.ok?(strict)
# becomes
result.ok?(strict: strict)

@anmarchenko anmarchenko requested review from a team as code owners March 19, 2024 13:04
@anmarchenko anmarchenko merged commit e855998 into main Mar 19, 2024
27 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/test_with_cucumber_9.2 branch March 19, 2024 14:14
@github-actions github-actions bot added this to the 0.9.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@anmarchenko @juan-fernandez