Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide appraisal from running test tasks #16

Merged
merged 3 commits into from
Sep 6, 2023
Merged

hide appraisal from running test tasks #16

merged 3 commits into from
Sep 6, 2023

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Sep 5, 2023 •
edited
Loading

What does this PR do?
Simplifies testing rake task in the same sense as done in dd-trace-rb

Motivation
Streamlined developer experience for this gem

How to test the change?
Run in datadog-ci-rb

docker-compose run --rm datadog-ci-3.2 /bin/bash

bundle install

bundle exec appraisal install

bundle exec rake -T

bundle exec rake test:main
bundle exec rake test:rspec
bundle exec rake test:minitest
bundle exec rake test:cucmber

@anmarchenko anmarchenko requested a review from a team September 5, 2023 14:59
@anmarchenko anmarchenko marked this pull request as ready for review September 5, 2023 14:59
GustavoCaso
GustavoCaso reviewed Sep 5, 2023
View reviewed changes
Rakefile Outdated Show resolved Hide resolved
@anmarchenko anmarchenko merged commit 8e45767 into main Sep 6, 2023
5 checks passed
@GustavoCaso GustavoCaso deleted the anmarchenko/implement_test_tasks branch September 6, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GustavoCaso GustavoCaso GustavoCaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmarchenko @GustavoCaso