Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 1.0 branch into main #161

Merged
merged 147 commits into from
Apr 22, 2024
Merged

Merge 1.0 branch into main #161

merged 147 commits into from
Apr 22, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?

Merges all the changes from 1.0 branch into main as we are nearing the 1.0 release of datadog-ci library

@anmarchenko
Use datadog gem v2, ruby 2.7 is minimal supported version now
b8584d4
@anmarchenko
datadog_cov native extension
c5e22d6
@anmarchenko
test datadog_cov extension
b85198d
@anmarchenko
fix bool type compilation error
1df52e0
@anmarchenko
exclude native binary artifacts from gemspec
cdc74cb
@anmarchenko
don't run code coverage specs on JRuby
31f46a4
@anmarchenko
do not require native extension on JRuby
452812e
@anmarchenko
try again
0db6f74
@anmarchenko
don't use class name in top-level describe
987ccd0
@anmarchenko
ITR::Runner has thread local coverage collector
c97d3f3 
Git.root returns Dir.pwd if git is not available
@anmarchenko
gemfile updates
abf11af
@anmarchenko
ITR code coverage start/stop in Recorder
0ba3e9c
@anmarchenko
freeze source file name to reduce object allocations
90f4e61
@anmarchenko
frozen strings do not make it faster
23628ad
@anmarchenko
require native extension on ITR configuration step
15083dc
@anmarchenko
add Datadog::CI::Cov placeholder
c8e8d93
@anmarchenko
fix jruby tests
8d60f52
@anmarchenko
multithreaded code coverage and mixins tests
466a313
@anmarchenko
note that UTF-8 paths are not supported yet, will be added as an opt-…
284cdbd 
…in later
@anmarchenko
specs for ITR::Runner#start_coverage
270b349
@anmarchenko
add more specs, try to fix release spec with forcing encoding for git…
d1a1d27 
… ls-files output
@anmarchenko
exclude cov_spec in JRUby completely
ef9861f
@anmarchenko
move cov tests and skip them completely on JRuby
ddf9dbb
@anmarchenko
do not compile native extension on unsupported platforms
109ad1e
@anmarchenko
check that dd_cov_data->root pointer is not NULL to avoid segfault
caa5f15
@anmarchenko
minor fixes
116c38e
@anmarchenko
store root as RString; convert to char* before using it for prefix check
a71bf38
@anmarchenko
initialize dd_cov_data->mode field when allocating dd_cov_data struct
5b25390
@anmarchenko
use Queue to synchronize threads in multithreaded coverage spec
554a148
@anmarchenko
add a simple test for lines coverage
74efff3
@anmarchenko
add retries with exponential backoff on network errors
d01e18b
@anmarchenko
test ITR::Runner state after skippable tests configuration
10dc249
@anmarchenko
minor change for skippable spec
c794a19
@anmarchenko
mark tests as skipped by ITR if they are found in skippable set
b843562
@anmarchenko
do not send coverage events for tests skipped by test framework or by…
fd57ee3 
… ITR
@anmarchenko
disabling code coverage if ITR wants to skip test might break coverag…
95bada0 
…e for unskippable tests
@anmarchenko
ITR increments skipped tests count only after test is finished to acc…
2cc4971 
…ount for unskippable tests
@anmarchenko
set ITR tags with number of skipped tests when session ends
4179162
@anmarchenko
skipping tests by ITR implementation for minitest
79b9ead
@anmarchenko
write specs until the end
ab97de7
@anmarchenko
rename skipped by itr tag
3393eff
@anmarchenko
additionally use test.parameters when determining if test is skippable
5a36fe9
@anmarchenko
rspec support for ITR skipping
b476d8e
@anmarchenko
trying out approaches for test skipping support in cucumber
96183f0
@anmarchenko
finally working prototype
75c70e2
@anmarchenko
fix failing tests with datadog 2.0.0.beta2 and update datadog dependency
cd6ee1b
@anmarchenko
temporarily skip shallow clone tests
a6dbf60
@anmarchenko
cucumber test skipping implementation done
e31a740
@anmarchenko
rename TestRun.test_full_name to TestRun.skippable_test_id
b26de0f
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.25864% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 98.90%. Comparing base (c23eabe) to head (b26de0f).

Files Patch % Lines
lib/datadog/ci/git/local_repository.rb 92.30% 9 Missing ⚠️
lib/datadog/ci/itr/coverage/writer.rb 90.38% 5 Missing ⚠️
...b/datadog/ci/transport/event_platform_transport.rb 91.30% 4 Missing ⚠️
lib/datadog/ci/itr/runner.rb 97.33% 2 Missing ⚠️
lib/datadog/ci/configuration/settings.rb 80.00% 1 Missing ⚠️
lib/datadog/ci/test_visibility/recorder.rb 97.22% 1 Missing ⚠️
lib/datadog/ci/test_visibility/transport.rb 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   99.06%   98.90%   -0.17%     
==========================================
  Files         163      196      +33     
  Lines        7285     9326    +2041     
  Branches      309      404      +95     
==========================================
+ Hits         7217     9224    +2007     
- Misses         68      102      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review April 22, 2024 11:15
@anmarchenko anmarchenko requested review from a team as code owners April 22, 2024 11:15
romainkomorndatadog
romainkomorndatadog approved these changes Apr 22, 2024
View reviewed changes
Copy link

@romainkomorndatadog romainkomorndatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspected every line. LGTM.

@anmarchenko anmarchenko merged commit abea9c1 into main Apr 22, 2024
26 checks passed
@anmarchenko anmarchenko deleted the 1.0 branch April 22, 2024 11:21
@github-actions github-actions bot added this to the 1.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.beta4
Development

Successfully merging this pull request may close these issues.
3 participants
@anmarchenko @codecov-commenter @romainkomorndatadog