show alternative code organization around provider and extractor #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
commented
Sep 6, 2023
| Git::TAG_COMMIT_COMMITTER_NAME => git_commit_committer_name, | ||
| Git::TAG_COMMIT_MESSAGE => git_commit_message, | ||
| Git::TAG_COMMIT_SHA => git_commit_sha | ||
| Environment::TAG_JOB_NAME => @provider.job_name, |
There was a problem hiding this comment.
We could use delegate as well rather than calling @provider all the time 😄
GustavoCaso
force-pushed
the
move-provider-outside-extractor
branch
2 times, most recently
from
87800a5
to
4618739
Compare
GustavoCaso
force-pushed
the
move-provider-outside-extractor
branch
from
4618739
to
d94a26a
Compare
anmarchenko
approved these changes
Sep 6, 2023
anmarchenko
merged commit 2487504
into
anmarchenko/ci_vis_validate_git_tags
8 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to show @anmarchenko what I meant with better code organization for providers and extractor