include NOTICE file #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
approved these changes
Sep 6, 2023
LICENSE-3rdparty.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| Component,Origin,License,Copyright | |||
| dd-trace-rb,https://github.com/DataDog/dd-trace-rb,Apache 2.0,"Copyright 2016-Present Datadog, Inc." | |||
There was a problem hiding this comment.
I'm not entirely sure if you actually need this, since this is not 3rd party code (e.g. it's first party -- Datadog's). May be worth quickly double-checking with the team on #opensource.
There was a problem hiding this comment.
yeah, I had the same thought actually, was very on the fence whether to include it
I will exclude this for now and will add it if requested by opensource channel
anmarchenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds NOTICE and LICENSE-3rdparty.csv files
Motivation
Following the checklist on how to opensource software at Datadog
How to test the change?
read it