Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions for releases and code scanning #26

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

anmarchenko
Copy link
Member

@anmarchenko anmarchenko commented Sep 8, 2023

What does this PR do?
preparing for releases support and adding relevant GitHub actions

Motivation
Release 0.1.0 incoming

Additional notes
See my question on pushing gem to github packages - when does it happen?

How to test the change?
Did I miss anything?

@anmarchenko anmarchenko requested review from a team September 8, 2023 14:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #26 (5a47c09) into main (d6067d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          83       83           
  Lines        2563     2563           
  Branches       98       98           
=======================================
  Hits         2536     2536           
  Misses         27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anmarchenko anmarchenko marked this pull request as draft September 11, 2023 11:32
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

workflow_dispatch:
inputs:
push:
description: Push gem
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this input come from? under what conditions the gem is pushed to github packages?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_dispatch means that it can be manually triggered from Github UI

@anmarchenko anmarchenko marked this pull request as ready for review September 12, 2023 08:37
workflow_dispatch:
inputs:
push:
description: Push gem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_dispatch means that it can be manually triggered from Github UI

default: true
push:
branches:
- '**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to build the gem on every push on any branch? Wonder what's would be your thoughts on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea that every push produces artifact that is built and can be downloaded and tested somewhere, I could use it to automate https://github.com/DataDog/test-environment tests for example. I see no harm in it for now, this won't create any issues for us.

@anmarchenko anmarchenko merged commit ceee00f into main Sep 12, 2023
11 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/release_actions branch September 12, 2023 09:02
@github-actions github-actions bot added this to the 0.1.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants