-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions for releases and code scanning #26
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 83 83
Lines 2563 2563
Branches 98 98
=======================================
Hits 2536 2536
Misses 27 27 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
68bc2b5
to
5a47c09
Compare
workflow_dispatch: | ||
inputs: | ||
push: | ||
description: Push gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this input come from? under what conditions the gem is pushed to github packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow_dispatch
means that it can be manually triggered from Github UI
workflow_dispatch: | ||
inputs: | ||
push: | ||
description: Push gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow_dispatch
means that it can be manually triggered from Github UI
default: true | ||
push: | ||
branches: | ||
- '**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to build the gem on every push on any branch? Wonder what's would be your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea that every push produces artifact that is built and can be downloaded and tested somewhere, I could use it to automate https://github.com/DataDog/test-environment tests for example. I see no harm in it for now, this won't create any issues for us.
What does this PR do?
preparing for releases support and adding relevant GitHub actions
Motivation
Release 0.1.0 incoming
Additional notes
See my question on pushing gem to github packages - when does it happen?
How to test the change?
Did I miss anything?