Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies warnings #31

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Solving circular references warnings discovered during integration testing

Motivation
To be able to run ddtrace in CI with datadog-ci dependency without warnings

Additional Notes
I will publish 0.1.1 release after merging this PR to continue with phase 1 of the CI migration

How to test the change?
Unit tests

@anmarchenko anmarchenko changed the title remove unnecessry import of Environment from Environment::Extractor Fix circular dependencies warnings Sep 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #31 (1e7178d) into main (87fabd9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   98.94%   98.94%   -0.01%     
==========================================
  Files          83       83              
  Lines        2563     2562       -1     
  Branches       98       98              
==========================================
- Hits         2536     2535       -1     
  Misses         27       27              
Files Changed Coverage Δ
lib/datadog/ci/ext/environment/extractor.rb 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anmarchenko anmarchenko requested review from a team September 14, 2023 08:33
@anmarchenko anmarchenko marked this pull request as ready for review September 14, 2023 08:34
@anmarchenko anmarchenko merged commit bfbd2d0 into main Sep 14, 2023
11 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/fix_circular_references branch September 14, 2023 08:40
@github-actions github-actions bot added this to the 0.2.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants