Update core configs for datadog-ci #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssarily require specific files from external gems
anmarchenko
changed the title
TonyCTHsu
reviewed
Aug 17, 2023
| @@ -12,6 +12,10 @@ | |||
| end | |||
|
|
|||
| describe "#ci" do | |||
| after do | |||
| settings.reset! | |||
There was a problem hiding this comment.
Is this necessary?
I thought every test example, the settings would be created from subject.
There was a problem hiding this comment.
I copied it from ddtrace gem, good point, will try to delete it and run tests
There was a problem hiding this comment.
@TonyCTHsu removed it
TonyCTHsu
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying changes by @GustavoCaso from DataDog/dd-trace-rb#2988
Found a couple of more superfluous requires and using require where require_relative is in order - fixed.