Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show missing git fields instead of a generic message #1487

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tanishq-dubey
Copy link

What and why?

STAL-3069

  • If all required git tags are not in our analysis, we returned a generic failure message on payload upload. This made debugging difficult for users. We are now returning the specific git tags that are missing to make debugging easier.

How?

This change adds a new error message renderer for missing git fields, and changes the tag requirement logic to share it between the error renderer and the generatePayload check

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@tanishq-dubey tanishq-dubey self-assigned this Oct 31, 2024
@tanishq-dubey tanishq-dubey added enhancement New feature or request static-analysis Related to [sarif, sbom] chores Related to the CI or developer experience labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chores Related to the CI or developer experience enhancement New feature or request static-analysis Related to [sarif, sbom]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant