Skip to content

Conversation

litianningdatadog
Copy link
Contributor

As bottlecap silently handles the API key access related errors(1, 2, 3), it nulls the necessity of keeping idle call. Hence we decided to clean it up.

Scenario Before the change After the change Conclusion
Normal link link
No key link link No diverging behavior observed
Empty key link link No diverging behavior observed
Invalid key link link No diverging behavior observed

@litianningdatadog litianningdatadog requested a review from a team as a code owner August 14, 2025 21:13
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this idle loop, even if we don't use it for API Key, it's good to have an idle loop when something unexpected crashes

@litianningdatadog litianningdatadog marked this pull request as draft August 18, 2025 14:01
@duncanista
Copy link
Contributor

Closing due to stale

@duncanista duncanista closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants