Add Start-Stop to Actions and Resources in Browser-RUM#957
Add Start-Stop to Actions and Resources in Browser-RUM#957BeltranBulbarellaDD wants to merge 12 commits intodevelopfrom
Conversation
🔀 Merge develop to main
…DK. Add to test screen.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd2b8a8f12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BeltranBulbarellaDD
changed the title
…ort adding it at stop.
|
@codex pls review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0e1e130ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fuzzybinary
left a comment
fuzzybinary
left a comment
There was a problem hiding this comment.
This is looking good. Few minor tweeks I think you might want to make then we can merge it in.
packages/datadog_flutter_plugin/integration_test_app/integration_test/rum_manual_test.dart
Show resolved
Hide resolved
|
@fuzzybinary thanks for the comments! I added the size property on the Browser-SDK and passed it down here and added it to the tests. This will make the tests fail until we release, so I'll keep in draft until the release and CI is green! |
2 participants
What and why?
After v6.28.0 In Browser SDK we now support Start-Stop Actions and Resources.
The objective of this PR is to replace Flutter's implementation with the usage from the Browser-SDK.
This Jira Issue
This RFC
How?
Review checklist