Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
dmehala authored May 15, 2024
1 parent cf845ff commit a905e1f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion examples/http-server/proxy/proxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ int main() {

dd::Tracer tracer{*finalized_config};

httplib::Client upstream_client("server", 8080);
httplib::Client upstream_client("server", 80);

// Configure the HTTP server.
auto forward_handler = [&tracer, &upstream_client](
Expand Down
1 change: 0 additions & 1 deletion test/test_span.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,6 @@ TEST_CASE("injecting W3C tracestate header") {
span->inject(writer);

CAPTURE(writer.items);
// TODO: substitue parent ID in tracestate
const auto found = writer.items.find("tracestate");
REQUIRE(found != writer.items.end());

Expand Down

0 comments on commit a905e1f

Please sign in to comment.