Generalize remote config #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/datadog/datadog_agent.cpp src/datadog/datadog_agent_config.cpp src/datadog/datadog_agent_config.h src/datadog/remote_config.cpp src/datadog/remote_config.h src/datadog/tracer.cpp src/datadog/tracer_config.cpp test/test_remote_config.cpp test/test_tracer.cpp
Directly converting a json node into std::vector<string::view> doesn't owkr in older GCCs (tried: 8.3.0)
cataphract
force-pushed
the
glopes/rem-cfg
branch
from
d9fe67f to
4b8be2c
Compare
cataphract
force-pushed
the
glopes/rem-cfg
branch
from
1e51ed4 to
195ee07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 94.48% 93.32% -1.16%
==========================================
Files 71 72 +1
Lines 3716 4120 +404
==========================================
+ Hits 3511 3845 +334
- Misses 205 275 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
estringana
approved these changes
Jun 10, 2024
dmehala
requested changes
Jun 10, 2024
There was a problem hiding this comment.
I am working on a simpler implementation: https://github.com/DataDog/dd-trace-cpp/tree/dmehala/remote-config-module
ETA reviewable this week.
The |
|
Resolved in #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general mechanism to subscribe to products. The user provides an arbitrary number of ProductListeners (listening to new configuration and to configuration renewal) and listeners running after all the ProductListeners have run.
Made a number of other improvements: RCTE2 support, check against the length, sending cached_target_files to avoid resending of configuration, and so on.