feat: extract/inject datadog tracestate field p
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
changed the title
dmehala
force-pushed
the
dmehala/w3c-p-tracestate
branch
from
9e3ee6c to
28e2b0c
Compare
Add support for W3C datadog tracestate field `p`.
dmehala
force-pushed
the
dmehala/w3c-p-tracestate
branch
from
28e2b0c to
674b5bf
Compare
dmehala
changed the title
p
dmehala
commented
May 7, 2024
pablomartinezbernardo
approved these changes
May 14, 2024
| @@ -300,6 +308,7 @@ Expected<ExtractedData> extract_w3c( | |||
| return result; | |||
| } | |||
|
|
|||
| result.datadog_w3c_parent_id = "0000000000000000"; | |||
There was a problem hiding this comment.
Curious to know: Is there a reason to use 0s id instead of an empty field somehow? Is the all 0s value a special value somewhere else?
There was a problem hiding this comment.
It's from the RFC. I think it's an optimization for the backend.
dmehala
commented
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for W3C datadog tracestate field
p.